[PATCH] D158497: [UTC] Keep function args parenthesis on label line (bumps version to 3)

[Jannik Silvanus via Phabricator via llvm-commits]

jsilvanus added inline comments.


================
Comment at: llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/named_function_arguments_split.ll.expected:10
+; CHECK-LABEL: define i32 @foo(
+; CHECK-SAME: i32 [[NAMED:%.*]]) {
 ; CHECK-NEXT:  entry:
----------------
nikic wrote:
> This would also match if there's extra arguments before it, but I guess that's a less likely situation. Unless there's a way to get both, moving the parentheses seems fine...
Good point. I don't see a way to support both at this point, but it would be possible with FileCheck support, e.g. a `CHECK-SAME` variant that requires a match to start right at the end of the previous match, similar to what `CHECK-NEXT` does with lines.

I'm committing this as-is to fix the existing issue of incorrect matches.
We can add the FileCheck support later if needed.  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158497/new/

https://reviews.llvm.org/D158497