[PATCH] D159056: [InstCombine] Make `isFreeToInvert` check recursively.

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 29 03:32:16 PDT 2023


nikic added a comment.

The change itself looks fine to me, but the test changes don't look particularly compelling...



================
Comment at: llvm/test/Transforms/LoopVectorize/reduction-inloop.ll:1362
+; CHECK-NEXT:    [[DOTNOT7:%.*]] = and <4 x i1> [[TMP45]], [[TMP19]]
+; CHECK-NEXT:    [[NOT__NOT7:%.*]] = xor <4 x i1> [[DOTNOT7]], <i1 true, i1 true, i1 true, i1 true>
+; CHECK-NEXT:    [[TMP46:%.*]] = bitcast <4 x i1> [[NOT__NOT7]] to i4
----------------
This looks like a regression?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159056/new/

https://reviews.llvm.org/D159056



More information about the llvm-commits mailing list