[PATCH] D158864: [Code Coverage] Add a script to check code coverage of a patch

[Henrik G Olsson via Phabricator via llvm-commits]

hnrklssn added inline comments.


================
Comment at: llvm/utils/git-check-coverage:48
+
+    except subprocess.CalledProcessError as e:
+        print("Error while creating the patch from the last commit:", e)
----------------
We should not continue executing the script after catching the errors


================
Comment at: llvm/utils/git-check-coverage:121-134
+        cmake_command = [
+            "cmake",
+            "-G",
+            "Ninja",
+            llvm_source_dir,
+            "-DCMAKE_BUILD_TYPE=Release",
+            "-DLLVM_ENABLE_ASSERTIONS=ON",
----------------
We should only add the flags we need to an existing cmake config


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158864/new/

https://reviews.llvm.org/D158864