[PATCH] D156238: [InstCombine] Generalize foldICmpWithMinMax

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n added a comment.

Think mostly looks good.



================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp:5048
+        // max(X, Y) >= Z   X >= Z  true
+        return FoldIntoConstant(true);
+      else
----------------
nit: Braces because so many lines (or move comments to before the if). Also you need need the `else` in the two blocks b.c return in `if`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156238/new/

https://reviews.llvm.org/D156238