[PATCH] D158907: [RISCV][GlobalISel] Select G_ICMP, G_IMPLICIT_DEF

[Nitin John Raj via Phabricator via llvm-commits]

nitinjohnraj planned changes to this revision.
nitinjohnraj added a comment.

We should try adding the rules to the tablegen.



================
Comment at: llvm/lib/Target/RISCV/GISel/RISCVInstructionSelector.cpp:222
+                               .addReg(RISCV::X0)
+                               .addImm(false);
+    return constrainSelectedInstRegOperands(*Result, TII, TRI, RBI);
----------------
Make this 0


================
Comment at: llvm/lib/Target/RISCV/GISel/RISCVInstructionSelector.cpp:235
+
+    if (!HasImm)
+      break;
----------------
Nest if statements


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158907/new/

https://reviews.llvm.org/D158907