[PATCH] D143108: [Asan] Add "funclet" OpBundle to Asan calls that are generated inside a funclet

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 28 14:59:42 PDT 2023

vitalybuka added inline comments.

Comment at: llvm/test/Instrumentation/AddressSanitizer/asan-funclet.ll:3
+; RUN: opt -S -passes=asan -asan-instrumentation-with-call-threshold=0 < %s | FileCheck %s
aeubanks wrote:
> saudi wrote:
> > aeubanks wrote:
> > > please use `llvm/utils/update_test_checks.py` instead of manual CHECK lines
> > The pass introduces a lot of instructions and a few basic blocks. The output of update_test_checks.py gets large and too specific for testing this particular feature. It would easily break when asan gets modified in the future.
> > 
> > This is my first time using that script. Is the usual approach to apply `update_test_checks.py` and only keep the `CHECK` lines necessary with potential minor modifications?
> > 
> > 
> typically yeah we still recommend people to use update_test_checks.py since updating them is easy if other patches change the tests, and manual checks are error-prone and can often become obsolete. but most asan tests aren't using it so this is fine
Can you please precommit the  test generated with update_test_checks without your patch
so in this patch we can see a difference in generated code.
Assuming compiler does not crash without the patch.



More information about the llvm-commits mailing list