[PATCH] D158961: [ThinLTO] Mark callers of local ifunc not eligible for import

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 28 14:01:53 PDT 2023


tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

lgtm except one comment in the test needs clarification.



================
Comment at: llvm/test/ThinLTO/X86/ifunc-import.ll:13
+
+;; The ifunc implementations are internal in A, so they cannot be referenced by B.
+;; Our implementation actually ensures that the ifunc resolver along with its
----------------
This seems to be specifically about @foo.ifunc, not @foo.ifunc2 which is not internal and for which we can import a reference. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158961/new/

https://reviews.llvm.org/D158961



More information about the llvm-commits mailing list