[PATCH] D157030: InstCombine: Fold out scale-if-denormal pattern

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n added a comment.

This needs to be rebased.

Code looks good (once rebased) I'll test + accept.



================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp:3326
+                                          Value *Cmp1, Value *TrueVal,
+                                          Value *FalseVal, SelectInst &SI,
+                                          bool SelectIsNSZ) {
----------------
nit: Would replace `SelectInst &SI` with `Instruction * CxtI` here. `TrueVal`/`FalseVal` don't actually match the select operands heres which seems bugprone if at somepoint someone thinks "oh I can just get these from the select".



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157030/new/

https://reviews.llvm.org/D157030