[PATCH] D158497: [UTC] Keep function args parenthesis on label line (bumps version to 3)

Mon Aug 28 10:48:56 PDT 2023

nikic accepted this revision.
nikic added a comment.

In D158497#4621961 <https://reviews.llvm.org/D158497#4621961>, @jdoerfert wrote:

> Do we have a fixed policy on version bumps? This seems small enough to be applied to the repository, no?

As this change affects ~all tests, I think we do want to bump the version, even if the difference itself is small.

LGTM from my side.

================
Comment at: llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/named_function_arguments_split.ll.expected:10
+; CHECK-LABEL: define i32 @foo(
+; CHECK-SAME: i32 [[NAMED:%.*]]) {
 ; CHECK-NEXT:  entry:
----------------
This would also match if there's extra arguments before it, but I guess that's a less likely situation. Unless there's a way to get both, moving the parentheses seems fine...

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158497/new/

https://reviews.llvm.org/D158497