[PATCH] D158980: [DebugInfo][NFC] Move ObjC Selector name handling to lib DebugInfo

[Felipe de Azevedo Piovezan via Phabricator via llvm-commits]

fdeazeve added inline comments.


================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFAcceleratorTable.h:752
 
+struct ObjCSelectorNames {
+  StringRef Selector;
----------------
aprantl wrote:
> Why plural?
Because there are 4 such names. But to be honest, I'm not sure I understand what an objective C selector is; maybe just "ObjectiveCNames" would be better?


================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFAcceleratorTable.h:755
+  StringRef ClassName;
+  std::optional<StringRef> ClassNameNoCategory = std::nullopt;
+  std::optional<std::string> MethodNameNoCategory = std::nullopt;
----------------
aprantl wrote:
> Is the `=` part necessary or will it be default constructed as empty like `llvm::Optional`?
It is constructed empty like an `llvm::Optional`, so this `= std::nullopt` is not needed, I'll remove it.


================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFAcceleratorTable.h:757
+  std::optional<std::string> MethodNameNoCategory = std::nullopt;
+};
+
----------------
aprantl wrote:
> If there are any comments to explain the latter two members, that would be nice.
I'll do some research to figure out what they actually are and add some comments


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158980/new/

https://reviews.llvm.org/D158980