[PATCH] D158837: [ConstraintElim] Store conditional facts as (Predicate, Op0, Op1).

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/ConstraintElimination.cpp:111
   bool Not;
+  bool HasCond = false;
 
----------------
The flags here have become something of a mess. Can we represent these as an enum instead? Something like...

```
enum {
  /// Fact implied by Inst, holds from the definition point of Inst.
  InstFact,
  /// Fact implied by Condition, holds from the start of the block.
  CondFact,
  /// Check at a specific use-site of an instruction.
  UseCheck,
  /// Check for all uses of an instruction.
  InstCheck,
}
```

...assuming those are the possible cases, of which I'm not really sure.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158837/new/

https://reviews.llvm.org/D158837