[PATCH] D158743: [Verifier] Sanity check alloca size against DILocalVariable fragment size

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 28 03:07:57 PDT 2023


nikic updated this revision to Diff 553880.
nikic added a comment.
Herald added a subscriber: fedor.sergeev.

I've submitted D158972 <https://reviews.llvm.org/D158972> to fix the clang bug.

An additional problem that turned up is that a number of tests that don't specify a target have 64-bit specific debuginfo and thus fail when tested against 32-bit targets. I've fixed these either by tweaking things to be pointer size independent, or by testing these using the x86_64 target. (The Generic/dwarf-public-names.ll test got dropped entirely, because X86/dwarf-public-names.ll already exists and is more extensive to boot.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158743/new/

https://reviews.llvm.org/D158743

Files:
  llvm/lib/IR/Verifier.cpp
  llvm/test/CodeGen/ARM/stack-frame-layout-remarks.ll
  llvm/test/CodeGen/BPF/warn-stack.ll
  llvm/test/CodeGen/X86/stack-frame-layout-remarks-32.ll
  llvm/test/CodeGen/X86/stack-frame-layout-remarks-64.ll
  llvm/test/CodeGen/X86/stack-frame-layout-remarks.ll
  llvm/test/DebugInfo/Generic/PR20038.ll
  llvm/test/DebugInfo/Generic/discriminated-union.ll
  llvm/test/DebugInfo/Generic/dwarf-public-names.ll
  llvm/test/DebugInfo/Generic/member-order.ll
  llvm/test/DebugInfo/Generic/tu-composite.ll
  llvm/test/DebugInfo/Generic/univariant-discriminated-union.ll
  llvm/test/DebugInfo/X86/PR20038.ll
  llvm/test/DebugInfo/X86/fi-piece.ll
  llvm/test/DebugInfo/X86/member-order.ll
  llvm/test/DebugInfo/X86/tu-composite.ll
  llvm/test/DebugInfo/invalid-sizes.ll
  llvm/test/Linker/type-unique-odr-a.ll
  llvm/test/Linker/type-unique-odr-b.ll
  llvm/test/Linker/type-unique-simple2-a.ll
  llvm/test/Linker/type-unique-simple2-b.ll
  llvm/test/Transforms/InstCombine/dbg-scalable-store-fixed-frag.ll
  llvm/test/Transforms/InstCombine/dbg-simplify-alloca-size.ll
  llvm/test/Transforms/Util/dbg-user-of-aext.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D158743.553880.patch
Type: text/x-patch
Size: 37139 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230828/3121b6c4/attachment-0001.bin>


More information about the llvm-commits mailing list