[PATCH] D158871: [CodeGen][AArch64] Precommit tests for D156767 (NFC)

Mingming Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 28 01:15:42 PDT 2023


mingmingl accepted this revision.
mingmingl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/CodeGen/AArch64/branch-relax-cross-section.mir:177
+
+  attributes #0 = { nounwind }
+
----------------
nit: it seems attribute #0 is not used. Maybe remove it.


================
Comment at: llvm/test/CodeGen/AArch64/branch-relax-cross-section.mir:493-496
+frameInfo:
+  stackSize:       112
+  maxAlignment:    16
+stack:
----------------
For my information, are 'frameInfo'/'stack' used here? If not, maybe simplify the test case a little bit. https://llvm.org/docs/MIRLangRef.html#simplifying-mir-files has some general tips; and some of them might be already applied here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158871/new/

https://reviews.llvm.org/D158871



More information about the llvm-commits mailing list