[PATCH] D157068: [Attributor] New attribute to identify what byte ranges are alive for an allocation

[Vidhush Singhal via Phabricator via llvm-commits]

vidsinghal added inline comments.


================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:5973
+    AAPointerInfoOffsetBins = Bins;
+  }
+
----------------
jdoerfert wrote:
> This is not a good idea. What happend to the old API you had?
> We do not want to leak out the underlying map if we don't have to.
> All you want is a `size` and `begin`/`end`, no?
> 
Yeah I see. 
The underlying map is protected in the state I think. 
Yeah for now, size begin and end should be good. 
I think I will try making those virtual pure in AAPointerInfo and then override them in the state? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157068/new/

https://reviews.llvm.org/D157068