[PATCH] D158332: [LV] Use IRBuidlder to create middle-block compare.

[Ayal Zaks via Phabricator via llvm-commits]

Ayal added a comment.

Rather than have IRBuilder detect and optimize this implicitly at code-gen/ILV::completeLoopSkeleton() time, better do so explicitly at VPlan transform time, probably after VF and UF have been set, i.e., optimize the compare and conditional branch recipes into an unconditional branch recipe. Is the intent to do so as a subsequent patch? If so would be good to add a TODO to replace IRBuilder here; code-gen should ideally be straightforward.

nit: typo in title. The use of IRBuilder to create the compare also optimizes it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158332/new/

https://reviews.llvm.org/D158332