[PATCH] D158950: [X86][BF16] Lower FP_EXTEND for vector types under AVX512BF16

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.h:1758
 
-    template<typename T> bool isSoftFP16(T VT) const;
+    template<typename T> bool isSoftF16(T VT) const;
 
----------------
is it necessary to keep this? or just always use the static variant inside X86ISelLowering.cpp?


================
Comment at: llvm/test/CodeGen/X86/bfloat.ll:1518
+; SSE2-NEXT:    movlhps {{.*#+}} xmm3 = xmm3[0],xmm4[0]
+; SSE2-NEXT:    retq
+;
----------------
how come this is scalarized given how easy it is to bit-twiddle bfloat to float?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158950/new/

https://reviews.llvm.org/D158950