[llvm] 1b4932e - [Pass] Enable detailed structural hashing
Aiden Grossman via llvm-commits
llvm-commits at lists.llvm.org
Sat Aug 26 00:56:31 PDT 2023
Author: Aiden Grossman
Date: 2023-08-26T00:53:52-07:00
New Revision: 1b4932e140ea6655a3e88a31984b58e300fc3c1e
URL: https://github.com/llvm/llvm-project/commit/1b4932e140ea6655a3e88a31984b58e300fc3c1e
DIFF: https://github.com/llvm/llvm-project/commit/1b4932e140ea6655a3e88a31984b58e300fc3c1e.diff
LOG: [Pass] Enable detailed structural hashing
Now that https://reviews.llvm.org/D158898 has been landed, fixing
https://github.com/llvm/llvm-project/issues/64938, we can now enable
detailed structural hashing to check pass modification status during
expensive checks as (it appears) there are no more passes incorrectly
setting the modification status.
This also acts as test coverage for the previous patch.
Added:
Modified:
llvm/lib/IR/Pass.cpp
Removed:
################################################################################
diff --git a/llvm/lib/IR/Pass.cpp b/llvm/lib/IR/Pass.cpp
index b92838d2e50ac7..d6096ebb3af700 100644
--- a/llvm/lib/IR/Pass.cpp
+++ b/llvm/lib/IR/Pass.cpp
@@ -139,14 +139,12 @@ LLVM_DUMP_METHOD void Pass::dump() const {
#endif
#ifdef EXPENSIVE_CHECKS
-// TODO: Use detailed structural hashing once exposed bugs have been fixed/
-// (https://github.com/llvm/llvm-project/issues/64938)
uint64_t Pass::structuralHash(Module &M) const {
- return StructuralHash(M, false);
+ return StructuralHash(M, true);
}
uint64_t Pass::structuralHash(Function &F) const {
- return StructuralHash(F, false);
+ return StructuralHash(F, true);
}
#endif
More information about the llvm-commits
mailing list