[PATCH] D158908: AMDGPU: Turn pow libcalls into powr
Stanislav Mekhanoshin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 25 17:09:18 PDT 2023
rampitec added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULibCalls.cpp:855
+ // TODO: Pass all arguments to cannotBeOrderedLessThanZero
+ if (PowrFunc && cannotBeOrderedLessThanZero(opr0, M->getDataLayout())) {
+ cast<CallInst>(FPOp)->setCalledFunction(PowrFunc);
----------------
Can you check the value before inserting declaration? Just to avoid unused declarations. Plus the way it is now you may return false when you have actually modified the module.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158908/new/
https://reviews.llvm.org/D158908
More information about the llvm-commits
mailing list