[PATCH] D158799: [llvm-nm][WebAssembly] Report the size of data symbols

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 25 15:59:06 PDT 2023


sbc100 added a comment.

In D158799#4618817 <https://reviews.llvm.org/D158799#4618817>, @dschuff wrote:

> In D158799#4618789 <https://reviews.llvm.org/D158799#4618789>, @sbc100 wrote:
>
>> In D158799#4618705 <https://reviews.llvm.org/D158799#4618705>, @dschuff wrote:
>>
>>> Otherwise this looks good.
>>
>> I added a function symbol.
>>
>> I'm not sure its worth adding a BSS symbol.   They are only distinguished by the segment in which they live (name starting with `.bss`... otherwise there is nothing special about them. )
>
> Do they have a size? 
> Actually, what is the size supposed to represent? The size in the file or the initialized size in wasm memory? I guess in other platforms its the virtual memory size, right?

yes they have a size just like any other data symbol.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158799/new/

https://reviews.llvm.org/D158799



More information about the llvm-commits mailing list