[PATCH] D144872: [AIX] Align the content of an xcoff object file which has auxiliary header in big archive.
Digger Lin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 25 15:45:56 PDT 2023
DiggerLin added inline comments.
================
Comment at: llvm/lib/Object/ArchiveWriter.cpp:526-527
+ // 'MaxAlignOfData' in the AuxiliaryHeader.
+ if (AuxHeaderSize < offsetof(AuxiliaryHeader, ModuleType))
+ return MinBigArchiveMemDataAlign;
+
----------------
DiggerLin wrote:
> jhenderson wrote:
> > This doesn't seem to be covered?
> Are we need a test case to cover all the statement ?
I added a test scenario for it anyway.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144872/new/
https://reviews.llvm.org/D144872
More information about the llvm-commits
mailing list