[PATCH] D144872: [AIX] Align the content of an xcoff object file which has auxiliary header in big archive.

[Digger Lin via Phabricator via llvm-commits]

DiggerLin added inline comments.


================
Comment at: llvm/lib/Object/ArchiveWriter.cpp:526-527
+  // 'MaxAlignOfData' in the AuxiliaryHeader.
+  if (AuxHeaderSize < offsetof(AuxiliaryHeader, ModuleType))
+    return MinBigArchiveMemDataAlign;
+
----------------
jhenderson wrote:
> This doesn't seem to be covered?
Are we need a test case to cover all the statement ?


================
Comment at: llvm/lib/Object/ArchiveWriter.cpp:837
+        if (Error Err = SetNextSymFile(Buf, M->MemberName))
+          return std::move(Err);
+
----------------
jhenderson wrote:
> Test case needed.
we just refactor the code here, not adding a new functionality here, I do not think we need a new test case here. 


================
Comment at: llvm/lib/Object/ArchiveWriter.cpp:844
+                                       (M + 1)->MemberName))
+          return std::move(Err);
+    }
----------------
jhenderson wrote:
> Test case needed.
some reason as above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144872/new/

https://reviews.llvm.org/D144872