[PATCH] D158799: [llvm-nm][WebAssembly] Report the size of data symbols

[Derek Schuff via Phabricator via llvm-commits]

dschuff added a comment.

Otherwise this looks good.



================
Comment at: llvm/test/tools/llvm-nm/wasm/print-size.test:28
+
+# CHECK: 00000000 00000020 D a_symbol
----------------
jhenderson wrote:
> Perhaps worth showing that a symbol that isn't in the data segment doesn't have a size printed too?
+1, showing other symbol kinds seems like a good idea as long as we're creating this test. Maybe get one  BSS and a function symbol?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158799/new/

https://reviews.llvm.org/D158799