[PATCH] D158892: [lld][WebAssembly] Add `--table-base` setting

[Derek Schuff via Phabricator via llvm-commits]

dschuff accepted this revision.
dschuff added a comment.
This revision is now accepted and ready to land.

LGTM otherwise



================
Comment at: lld/test/wasm/table-base.s:27
+# CHECK-DEFAULT-NEXT:    Globals:
+# CHECK-DEFAULT-NEXT:      - Index:           0
+# CHECK-DEFAULT-NEXT:        Type:            I32
----------------
what is this global 0 for?


================
Comment at: lld/test/wasm/table-base.s:67
+# CHECK-100-NEXT:          Opcode:          I32_CONST
+# CHECK-100-NEXT:          Value:           100
+
----------------
seems like maybe it's worth noting somehow that this line is the important one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158892/new/

https://reviews.llvm.org/D158892