[PATCH] D158817: [CSSPGO] Refactoring populateIRLocations and countProfileMismatches

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 25 13:18:02 PDT 2023


wenlei added a comment.

looks cleaner and more structured now, thanks for update!



================
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:2383-2384
+      !ProbeManager->profileIsValid(F, FS)) {
     LLVM_DEBUG(dbgs() << "Run stale profile matching for " << F.getName()
                       << "\n");
     // The matching result will be saved to IRToProfileLocationMap, create a new
----------------
nit: move this into `runStaleProfileMatching` as well?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158817/new/

https://reviews.llvm.org/D158817



More information about the llvm-commits mailing list