[PATCH] D158879: [RISCV] Improve splatPartsI64WithVL for vlmax scalable vector constants where Hi and Lo are the same.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 25 13:04:13 PDT 2023


craig.topper added a comment.

In D158879#4618125 <https://reviews.llvm.org/D158879#4618125>, @reames wrote:

> LGTM
>
> As I follow up, I'd be really tempted to just double the VL.  At a minimum, doing so for constants encodable in vsetivli seems like a clear win.

Yep that's exactly the change that's needed to improve the output of D158870 <https://reviews.llvm.org/D158870>. We have to be careful so that doubling doesn't turn something like 0x80000000 into 0. So constants are a lot easier than arbitrary VL.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158879/new/

https://reviews.llvm.org/D158879



More information about the llvm-commits mailing list