[PATCH] D158676: [NFC][AsmPrinter] Remove dead multi-MMI handling from DwarfFile::addScopeVariable

[Felipe de Azevedo Piovezan via Phabricator via llvm-commits]

fdeazeve accepted this revision.
fdeazeve added a comment.
This revision is now accepted and ready to land.

LGTM! Thanks for doing this



================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:324
+      }))
+    FrameIndexExprs.push_back({FI, Expr});
 
----------------
As a follow up comment on the mutable thing in the other revision, if `FrameIndexExprs` were a `set` we wouldn't need this call to `none_of` nor the mutable member. Also not something for this patch though!


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:1572
+
+    if (DbgVariable *DbgVar = MFVars.lookup(Var)) {
+      if (DbgVar->hasFrameIndexExprs())
----------------
Yes! Really glad we now query _before_ creating the new Dbg var!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158676/new/

https://reviews.llvm.org/D158676