[PATCH] D156954: [lit] Improve test output from lit's internal shell

Joel E. Denny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 25 10:58:57 PDT 2023


jdenny added a comment.

I saw only one bit of feedback from the RFC that affects this patch.  That is, theoretically, a windows user might wish to adjust the shell comment sequence that lit's internal shell uses in its execution trace.  This feature might help with copying multiple command lines at once from that trace and pasting them into any of the various shells that people use in windows.  However, people seemed fine to wait to do that in a separate patch if an actual user who cares about that use case speaks up.

At this point, I think we're just waiting on D154984 <https://reviews.llvm.org/D154984> to be accepted.

@ldionne In the meantime, if it hasn't happened already, it might be good for a libcxx person to review the libcxx changes in this patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156954/new/

https://reviews.llvm.org/D156954



More information about the llvm-commits mailing list