[PATCH] D158655: [libunwind][AIX] Fix problem with stepping up from a leaf function when unwinding started in a signal handler

Xing Xue via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 25 10:56:18 PDT 2023


xingxue updated this revision to Diff 553541.
xingxue marked 4 inline comments as done.
xingxue added a comment.

Addressed comments:

- removed mentioning of buying stack frame in a code comment
- added `if (!lastStack)` and under the condition, set `returnAddress` to NULL
- removed condition `TBTable->tb.saves_lr || !lastStack` when restoring SP
- added code to initialize the LR value in context to 0


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158655/new/

https://reviews.llvm.org/D158655

Files:
  libunwind/src/Registers.hpp
  libunwind/src/UnwindCursor.hpp
  libunwind/src/UnwindRegistersSave.S
  libunwind/test/aix_signal_unwind.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D158655.553541.patch
Type: text/x-patch
Size: 7746 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230825/119dff2d/attachment.bin>


More information about the llvm-commits mailing list