[PATCH] D158852: [SDAG] Add computeKnownBits support for ISD::SPLAT_VECTOR_PARTS
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 25 10:39:34 PDT 2023
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: llvm/test/CodeGen/RISCV/rvv/vror-sdnode.ll:2063
-; CHECK-RV32-NEXT: vsetvli a0, zero, e64, m8, ta, ma
-; CHECK-RV32-NEXT: vmv.v.i v16, 1
-; CHECK-RV32-NEXT: vrsub.vi v16, v16, 0
----------------
There's a missed constant fold of sub of two constant splat_vector parts here. computeKnownBits is hiding it because we constant fold it inside computeKnownBits, but we should handle it in FoldConstantArithmetic
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158852/new/
https://reviews.llvm.org/D158852
More information about the llvm-commits
mailing list