[PATCH] D158280: [jitlink/rtdydl][checker] Construct disassembler at every decodeInst

Eymen Ünay via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 25 09:19:13 PDT 2023


Eymay added inline comments.


================
Comment at: llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldChecker.cpp:299
+        return std::make_pair(EvalResult(ErrMsgStream.str()), "");
+      }
+      Inst.dump_pretty(ErrMsgStream, InstPrinter.get().get());
----------------
Is there a way we could try alternative triples when there is a fail? The reason is if somehow TargetFlag emission has a problem, the triple is wrong and MCDisassembler fails terribly. How should the error be handled in RuntimeDyld setting?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158280/new/

https://reviews.llvm.org/D158280



More information about the llvm-commits mailing list