[PATCH] D158850: RegisterCoalescer: Correctly set valid lanes when keeping live out implicit defs

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 25 08:03:39 PDT 2023


arsenm created this revision.
arsenm added reviewers: MatzeB, qcolombet, kparzysz, uabelho, wmi, foad, tpr, dstuttard, bjope.
Herald added subscribers: StephenFan, pengfei, hiraditya.
Herald added a project: All.
arsenm requested review of this revision.
Herald added a subscriber: wdng.
Herald added a project: LLVM.

This fixes some verifier errors when live out implicit defs are
coalesced with identity copies. Fixes some reduced testcases from
issue #38788 but doesn't solve the original failure.

      

I was surprised this seems to obviate the special casing in
analyzeValue that's been there since the subregister liveness support
went in.


https://reviews.llvm.org/D158850

Files:
  llvm/lib/CodeGen/RegisterCoalescer.cpp
  llvm/test/CodeGen/X86/pr38795-verifier-error-pr38788.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D158850.553477.patch
Type: text/x-patch
Size: 8399 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230825/47016af5/attachment-0001.bin>


More information about the llvm-commits mailing list