[PATCH] D158845: [NFC][AMDGPU] assert we've found a value before use

[Luke Drummond via Phabricator via llvm-commits]

ldrumm planned changes to this revision.
ldrumm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUIGroupLP.cpp:597
+    SchedGroup *Match = nullptr;
     for (auto &SG : SyncPipeline) {
       if (SG.getSGID() == CandSGID)
----------------
jrbyrnes wrote:
> Can we convert these into std::find_if?
> 
>     SchedGroup *Match = std::find_if(
>         SyncPipeline.begin(), SyncPipeline.end(),
>         [&CandSGID](SchedGroup SG) { return SG.getSGID() == CandSGID; });
>     assert(Match != SyncPipeline.end());
Yeah. That'd work too. We can also use `llvm::find_if`, and capture `CandSGID` by value.
Updated


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158845/new/

https://reviews.llvm.org/D158845