[PATCH] D158846: [CMake] Fix BUILD_SHARED_LIBS build on Solaris

[Michał Górny via Phabricator via llvm-commits]

mgorny added inline comments.


================
Comment at: llvm/cmake/modules/AddLLVM.cmake:652
+    if(${CMAKE_SYSTEM_NAME} MATCHES "SunOS")
+      set_target_properties(${name} PROPERTIES INTERFACE_LINK_LIBRARIES m)
+    endif()
----------------
But is this dependency really specific to Solaris? I think that if we use `libm` stuff on all platforms, we should link to it whether the linker requires that or not.

That said, I don't know if the current policy is explicitly not do that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158846/new/

https://reviews.llvm.org/D158846