[PATCH] D158779: [VPlan] Add active-lane-mask as VPlan-to-VPlan transformation.

[Alexey Bataev via Phabricator via llvm-commits]

ABataev added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp:823
+  // Create the active lane mask instruction in the vplan preheader.
+  VPBasicBlock *VecPreheader =
+      cast<VPBasicBlock>(Plan.getVectorLoopRegion()->getSinglePredecessor());
----------------
`auto *`


================
Comment at: llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp:886
+
+  VPInstruction *BranchBack =
+      new VPInstruction(VPInstruction::BranchOnCond, {NotMask}, DL);
----------------
auto *


================
Comment at: llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp:903-904
+    }
+    if (Fn(U))
+      return;
+  }
----------------
Looks like boolean result of Fn is not used, you can make it simply return void.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158779/new/

https://reviews.llvm.org/D158779