[PATCH] D158566: Add CLANGD_INCLUDE_TESTS as a separate flag to control clangd tests

Fri Aug 25 01:28:06 PDT 2023

ilya-biryukov requested changes to this revision.
ilya-biryukov added a subscriber: sammccall.
ilya-biryukov added a comment.
This revision now requires changes to proceed.

Open question: I also feel like the best option here is to fix the tests, but I'm not sure how hard that would be. @sammccall any thoughts?
I suspect the particular tests are flaky is because they rely on timeouts, not sure it's easy to disentangle them. Therefore, some workaround seems reasonable

If we land this, we should ensure that when `CLANG_INCLUDE_TESTS` is off, Clangd tests don't run.
Clangd should respect the LLVM-wide options even if it has a more specific one for the project itself.

I'm marking as requiring changes mostly for the latter comment about `CLANG_INCLUDE_TESTS`.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158566/new/

https://reviews.llvm.org/D158566