[PATCH] D158004: llvm-nm ignore the Import symbol file for the --export-symbol option.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In D158004#4616384 <https://reviews.llvm.org/D158004#4616384>, @MaskRay wrote:

> Changing `llvm::identify_magic` to recognize all files starting with `#!` as `aix_linker_import_file` is not correct. Many can well be used as shebang for shell or other scripts.
>
>   case '#':
>     if (Magic[1] == '!')
>       return file_magic::aix_linker_import_file;
>     break;

How would you suggest that @DiggerLin proceeds then? The impact of misidentifying a file with a shebang as an AIX import file is that tools will no longer report "invalid object file" or something to that effect for such files, but will otherwise do nothing with them, so it seems relatively harmless to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158004/new/

https://reviews.llvm.org/D158004