[PATCH] D158604: [AMDGPU] Add llvm.amdgcn.set.inactive.chain.arg intrinsic

[Diana Picus via Phabricator via llvm-commits]

rovka added inline comments.


================
Comment at: llvm/include/llvm/IR/IntrinsicsAMDGPU.td:2116
 
+// Similar to int_amdgcn_set_inactive, but the value for the inactive lanes must
+// be a VGPR function argument.
----------------
arsenm wrote:
> why can't you just use set_inactive for this?
You can, we just didn't want to overload the meaning of that intrinsic. IIUC set.inactive only expects constants for the value of the inactive lanes (admittedly this is just word of mouth, a quick grep through existing tests, and the fact that the docs leave out the second source in "the instruction and the first source will be computed in WQM").  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158604/new/

https://reviews.llvm.org/D158604