[PATCH] D158375: [llvm-exegesis] Fix build for riscv32

Aiden Grossman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 25 00:05:38 PDT 2023


aidengrossman added reviewers: aidengrossman, courbet, gchatelet.
aidengrossman added a comment.

Once you adopt @MaskRay's comments regarding the comment wording and preprocessor directives, this should LGTM.

I'm surprised this wasn't caught earlier on (ideally soon after commit). It doesn't seem like there's any buildbot coverage for 32-bit RISCV? Not sure what would be involved in setting that up, but it would be nice to have the coverage to catch obvious regressions like this one more quickly rather than late in the release process.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158375/new/

https://reviews.llvm.org/D158375



More information about the llvm-commits mailing list