[PATCH] D148414: [InstCombine] Expand `foldSelectICmpAndOr` -> `foldSelectICmpAndBinOp` to work for more binops
Noah Goldstein via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 24 23:07:39 PDT 2023
goldstein.w.n added a comment.
In D148414#4616052 <https://reviews.llvm.org/D148414#4616052>, @chapuni wrote:
> Seems this still miscompiles `llvm-rc/ResourceFileWriter.cpp` for targeting x86-64. Investigating.
Are you certain its this? I just checked and the IR for `llvm-rc/ResourceFileWriter.cpp` is unchanged with/without this commit.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148414/new/
https://reviews.llvm.org/D148414
More information about the llvm-commits
mailing list