[PATCH] D158806: Cleanup remaining bits for Minix, Contiki and Myriad

[Brad Smith via Phabricator via llvm-commits]

brad added inline comments.


================
Comment at: llvm/lib/Support/Unix/Path.inc:129
 
-#if defined(__FreeBSD__) || defined(__NetBSD__) || defined(__OpenBSD__) ||     \
-    defined(__minix) || defined(__FreeBSD_kernel__) || defined(__linux__) ||   \
-    defined(__CYGWIN__) || defined(__DragonFly__) || defined(_AIX) ||          \
-    defined(__GNU__) || (defined(__sun__) && defined(__svr4__))
+#if defined(__FreeBSD__) || defined(__NetBSD__) || defined(__OpenBSD__) ||      \
+    defined(__FreeBSD_kernel__) || defined(__linux__) || defined(__CYGWIN__) || \
----------------
MaskRay wrote:
> (It seems that this can be replaced with `defined(__ELF__) && !defined(__Fuchsia__) || defined(_AIX)`), but your current code is safer..
> (It seems that this can be replaced with `defined(__ELF__) && !defined(__Fuchsia__) || defined(_AIX)`), but your current code is safer..

Ya, I wouldn't object to things of that nature as one or more separate commits.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158806/new/

https://reviews.llvm.org/D158806