[PATCH] D158379: [RISCV] Add bounds check before use on returned iterator during frame lowering.

[Anmol P. Paralkar via Phabricator via llvm-commits]

anmolparalkar-nxp updated this revision to Diff 553339.
anmolparalkar-nxp added a comment.

@garvitgupta08

Addressed review comments to llvm/test/CodeGen/RISCV/zcmp-prolog-epilog-crash.ll from D158256 <https://reviews.llvm.org/D158256>:

craig.topper:
-------------

Do we need the hidden and local_unnamed_addr attributes?

> DONE
======

icmp slt i32 poison, poison doesn't make sense. The compiler would be allowed to delete it. So a future optimization could break this test.

> DONE
======

store i32 0, ptr null, align 4 is a store to null which is undefined behavior. So the compiler is allowed to delete it. Again a future optimization could delete it and break this test.

> DONE
======

jrtc27:
-------

Use update_llc_test_checks.py

> DONE
======

Though why is there an IR test and a MIR test? The MIR test seems preferable, surely?

> Please feel free to drop: llvm/test/CodeGen/RISCV/zcmp-prolog-epilog-crash.ll
===============================================================================

Though it looks like the same code is generated for both so can share one prefix?

> Actually, there is a difference ...
=====================================

nounwind

> DONE
======

Space between declaration and definition

> DONE
======

Clean up the IR of these comments?

> DONE
======

Dangling attribute reference

> DONE
======

This seems overly-reduced

> Asked for clarification ...
=============================

Fix // No newline at end of file

> DONE?
=======


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158379/new/

https://reviews.llvm.org/D158379

Files:
  llvm/lib/Target/RISCV/RISCVFrameLowering.cpp
  llvm/test/CodeGen/RISCV/zcmp-prolog-epilog-crash.ll
  llvm/test/CodeGen/RISCV/zcmp-prolog-epilog-crash.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D158379.553339.patch
Type: text/x-patch
Size: 12197 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230825/a6c6cf27/attachment.bin>