[PATCH] D158723: [NFC][FuncSpec] Update the description of function specialization.

[Chuanqi Xu via Phabricator via llvm-commits]

ChuanqiXu accepted this revision.
ChuanqiXu added a comment.
This revision is now accepted and ready to land.

LGTM basically. Thanks.



================
Comment at: llvm/include/llvm/Transforms/IPO/FunctionSpecialization.h:23-25
+// exposes inlining opportunities which we would have otherwise missed. That's
+// why function specialization is run before the inliner in the optimization
+// pipeline; that is by design.
----------------
This is asked several times before. And it is indeed a little bit odd since inlining can cover function specialization abstractly. And we considered this when designing the cost model. What I wanted is to add a post-inlining function specialization pass which can be more aggressive on literal constants. Maybe it is worth to add this as a TODO? This is not required.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158723/new/

https://reviews.llvm.org/D158723