[PATCH] D158758: Revert some auto-generated checks where a wildcard was needed

Andy Kaylor via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 24 13:57:38 PDT 2023


andrew.w.kaylor added a comment.

In D158758#4614632 <https://reviews.llvm.org/D158758#4614632>, @nikic wrote:

> Can you change the constants to values that don't suffer from accuracy problems instead?

I don't think so -- at least not in all cases. For example, some of these checks are verifying that the pow(C,x) -> exp2(log2(C)*x) transformation happens in the presence of fast-math flags. If the computation returns an exact result, the fast-math flag isn't required.

Example: https://godbolt.org/z/MxjYbs6Ys


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158758/new/

https://reviews.llvm.org/D158758



More information about the llvm-commits mailing list