[PATCH] D158280: [jitlink/rtdydl][checker] Construct disassembler at every decodeInst

[Eymen Ünay via Phabricator via llvm-commits]

Eymay added inline comments.


================
Comment at: llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldChecker.cpp:945
+    logAllUnhandledErrors(SymInfo.takeError(), errs(), "RTDyldChecker: ");
+    return 0xFF;
+  }
----------------
TODO Added a tri-state for easier debugging, should be removed in the end


================
Comment at: llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldChecker.cpp:958
+    assert(static_cast<uint8_t>(Flag) != 0xFF && "Invalid target flag");
+    TheTriple.setArchName((Flag & 0x1
+                               ? (Twine("thumb") + TT.getArchName().substr(3))
----------------
Somehow this didn't fail but having the same consecutive flag should be failing it. This trickery was done to protect version numbers:

For example armv7-... should not become thumb-.. but instead thumbv7-... I'm a little surprised to not find an API for this case  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158280/new/

https://reviews.llvm.org/D158280