[PATCH] D158689: [llvm-profdata] Fix dangling reference after D147740

Alexander Yermolovich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 24 11:22:35 PDT 2023


ayermolo added a comment.

This does seem to fix memory corruption.
That being said I think I am with @wenlei on this. The implementation seems fragile as DenseMap, apparently, doesn't offer reference stability. Which leads to these kind of workarounds, and more then likely more issues down the road.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158689/new/

https://reviews.llvm.org/D158689



More information about the llvm-commits mailing list