[PATCH] D148414: [InstCombine] Expand `foldSelectICmpAndOr` -> `foldSelectICmpAndBinOp` to work for more binops

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n added a comment.

In D148414#4594813 <https://reviews.llvm.org/D148414#4594813>, @DavidSpickett wrote:

> I've confirmed just this commit is enough to hit the issue, and here's the reproducer: F28721703: X86ISelLowering-82e2a2.zip <https://reviews.llvm.org/F28721703>

Thank you for creating the repro and reverting this.
Issue was it was missing a nullptr check when checking the identity constant.

@nikic I've retested this. Going to repush in a few days unless anyone objects.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148414/new/

https://reviews.llvm.org/D148414