[PATCH] D146845: [FPEnv] [WIP] Verify strictfp attribute correctness, first part, 2023 edition

Kevin P. Neal via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 24 10:40:57 PDT 2023


kpn updated this revision to Diff 553187.
kpn added a comment.

Weaken the test. Now it only checks for the strictfp attribute on function calls if is found on the containing function definition. A call with the strictfp attribute in a function that lacks the strictfp attribute is allowed. Since we're also disallowing use of the constrained intrinsics without the strictfp attribute on the function definition the weakened test should be just as good as the previous iteration of this patch.

With this change to this patch I can abandon D157766 <https://reviews.llvm.org/D157766>. A failing Inliner test is also brought back by this change.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146845/new/

https://reviews.llvm.org/D146845

Files:
  llvm/lib/IR/Verifier.cpp
  llvm/test/Verifier/fp-intrinsics.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D146845.553187.patch
Type: text/x-patch
Size: 9055 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230824/3a1a33fc/attachment.bin>


More information about the llvm-commits mailing list