[PATCH] D158530: [InferAlignment] Create tests for InferAlignment pass

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

High level feedback on these tests: Due to where they came from, they are kind of all over the place. They are split across a large number of files, the test names are, to the most part, not meaningful for this pass, and occasionally there are comments that don't make sense in the context of this pass. I think this needs to be a lot more consolidated, with a better understanding of what each test is actually supposed to test.



================
Comment at: llvm/test/Transforms/InferAlignment/addrspace.ll:10
+
+define <4 x float> @constant_fold_bitcast_vector_as() {
+; CHECK-LABEL: define <4 x float> @constant_fold_bitcast_vector_as() {
----------------
Test name doesn't make sense, there is no bitcast here (and no gep below).


================
Comment at: llvm/test/Transforms/InferAlignment/basic.ll:57
+; those confuse the analysis into thinking that the second store does not alias
+; the first.
+
----------------
Comment makes no sense in the context of this pass.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158530/new/

https://reviews.llvm.org/D158530