[PATCH] D156505: [AArch64][ELF] Support R_AARCH64_AUTH_ABS64 static relocation

Thu Aug 24 08:38:05 PDT 2023

kovdan01 marked an inline comment as done.
kovdan01 added inline comments.

================
Comment at: llvm/test/MC/AArch64/elf-reloc-ptrauth.s:86
+
+.ifdef MCONLY
+
----------------
MaskRay wrote:
> By MCONLY you mean this is only used for `-filetype=asm` (default for llvm-mc)? I think using "MC" in this context is confusing.
> 
> `ASMONLY` may be better since -filetype=asm uses MCAsmStreamer, different from MCObjectStreamer used by -filetype=obj.
Changed to `ASMONLY`, it suites the case better, thanks

================
Comment at: llvm/test/MC/AArch64/elf-reloc-ptrauth.s:99
+.quad _g11 at AUTH(ia,42) + _g12 at AUTH(ia,42)
+
+.endif // MCONLY
----------------
MaskRay wrote:
> An subtraction expression test will be interesting as well.
> 
> The addition of two non-absolute symbols cannot be represented in the relocatable object file while the subtractions can often be represented. 
Implemented a one. Left a TODO regarding subtraction of an AUTH and non-AUTH symbols. Currently we emit an error in such a case, but we might not want such behavior since there is no difference whether the symbol is AUTH or not when computing compile-time-known distance. Please let me know your thought regarding that.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156505/new/

https://reviews.llvm.org/D156505