[PATCH] D157591: [AArch64][GlobalISel] Optimize Combine Funnel Shift

[Tuan Chuong Goh via Phabricator via llvm-commits]

chuongg3 added inline comments.


================
Comment at: llvm/include/llvm/Target/GlobalISel/Combine.td:824
+  (match (wip_match_opcode G_FSHL, G_FSHR):$root,
+    [{ return Helper.matchConstantLargerBitWidth(*${root}, 3); }]),
+  (apply [{ Helper.applyFunnelShiftConstantModulo(*${root}); }])
----------------
arsenm wrote:
> not sure if ImmLeafs work 
It looks like ImmLeaf will currently take a type and use an int64_t for the internal type. These patterns want to handle any types, so it doesn't look like they can be used as-is here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157591/new/

https://reviews.llvm.org/D157591